+1 (non-binding)

Downloaded, built, ran tests, checked L&N. Instructions on installing gradle 
were nice and clear.

I ran rat (I presume that ‘./gradlew rat’ is the correct command) and it passed.

I believe that best practice is to put the release bits under 
https://dist.apache.org/repos/dist/dev/${project}/${release} 
<https://dist.apache.org/repos/dist/dev/$%7Bproject%7D/$%7Brelease%7D> rather 
than under home.apache.org <http://home.apache.org/>. I suggest that Samza 
follows this for future releases.

The best place to put KEYS is 
https://dist.apache.org/repos/dist/dev/${project}/KEYS 
<https://dist.apache.org/repos/dist/dev/$%7Bproject%7D/KEYS>, not in git 
(because git can be subverted).

Should Gemfile.lock be in the release? Isn’t it a generated file?

Julian


> On Aug 1, 2016, at 1:05 PM, Navina Ramesh <nram...@linkedin.com.INVALID> 
> wrote:
> 
> @Garry: Yeah. I wasn't very clear about it either.
> 
> @Yi: Do you know if it is a part of the release process to add my keys to
> the KEYS file in git repo?
> 
> 
> Navina
> 
> On Mon, Aug 1, 2016 at 12:47 PM, Garry Turkington <
> g.turking...@improvedigital.com> wrote:
> 
>> +1 (binding)
>> 
>> Built the source ran all tests and tried a sample test job. All looks good.
>> 
>> One question - the key used to sign isn't in the KEYS file in the git repo
>> -- is this a convenieence mechanism or  does the release process mean it
>> should be there?
>> 
>> Garry
>> 
>> -----Original Message-----
>> From: Jacob Maes [mailto:jacob.m...@gmail.com]
>> Sent: Monday, August 01, 2016 7:45 PM
>> To: dev@samza.apache.org
>> Subject: Re: [DISCUSS] [VOTE] Apache Samza 0.10.1 RC0
>> 
>> +1 non-binding
>> Lots of good fixes in this release.
>> 
>> On Mon, Aug 1, 2016 at 11:41 AM, Jagadish Venkatraman <
>> jagadish1...@gmail.com> wrote:
>> 
>>> Thanks for driving this release.+1 approve (non-binding)
>>> 
>>> Thanks,
>>> Jagadish
>>> 
>>> On Mon, Aug 1, 2016 at 11:39 AM, Navina Ramesh
>>> <nram...@linkedin.com.invalid
>>>> wrote:
>>> 
>>>> Hey all,
>>>> 
>>>> This is a call for a vote on a release of Apache Samza 0.10.0.
>>>> Thanks to everyone who has contributed to this release. We are very
>>>> glad to see some new contributors in this release.
>>>> 
>>>> **NOTE**: This release is primarily a bug-fix release with no major
>>> changes
>>>> to the public api. Since we are behind schedule in terms of
>>>> releases, we are combining the DISCUSS and VOTE email into a single
>>>> VOTE email. If anyone has objections, please do raise them. We plan
>>>> to shortly follow-up with a DISCUSS email for 0.11.0 release, that
>>>> brings in new features in multi-threading, REST api etc.
>>>> 
>>>> 
>>>> The release candidate can be downloaded from here:
>>>> http://home.apache.org/~navina/samza-0.10.1-rc0/
>>>> 
>>>> 
>>>> The release candidate is signed with pgp key 331C8F69, which can be
>>>> found on keyservers:
>>>> http://pgp.mit.edu/pks/lookup?op=get&search=0x331C8F69
>>>> 
>>>> 
>>>> The git tag is release-0.10.1-rc0 and signed with the same pgp key:
>>>> *
>>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=33eff8a3e1
>>> eb2dc1dbffc661f910b1272b233640
>>>> <
>>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=33eff8a3e1
>>> eb2dc1dbffc661f910b1272b233640
>>>>> *
>>>> 
>>>> 
>>>> Test binaries have been published to Maven's staging repository, and
>>>> are available
>>>> here:
>>>> https://repository.apache.org/content/repositories/orgapachesamza-10
>>>> 12/
>>>> 
>>>> 
>>>> Note that the binaries were built with JDK7 without incident.
>>>> 
>>>> 69 issues were resolved for this release:
>>>> 
>>>> 
>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SAMZA%20AND
>>> %20fixVersion%20in%20(0.10.1)%20AND%20status%20in%20(Resolved%2C%20Clo
>>> sed)
>>>> 
>>>> 
>>>> The vote will be open for 72 hours ( end in 12:00pm Thursday,
>>>> 08/05/2016
>>> ).
>>>> 
>>>> 
>>>> Please download the release candidate, check the hashes/signature,
>>>> build it and test it, and then please vote:
>>>> 
>>>> 
>>>> [ ] +1 approve
>>>> 
>>>> [ ] +0 no opinion
>>>> 
>>>> [ ] -1 disapprove (and reason why)
>>>> 
>>>> 
>>>> +1 from my side for the release.
>>>> 
>>>> Cheers!
>>>> --
>>>> Navina R.
>>>> nav...@apache.org
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Jagadish V,
>>> Graduate Student,
>>> Department of Computer Science,
>>> Stanford University
>>> 
>> 
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2016.0.7688 / Virus Database: 4627/12695 - Release Date: 07/27/16
>> 
> 
> 
> 
> -- 
> Navina R.

Reply via email to