> On July 22, 2016, 10:04 p.m., Yi Pan (Data Infrastructure) wrote: > > Do we still want to keep this??? We do not support migration from 0.9 > > directly to 0.11. And the code here is to migrate 0.9 jobs to 0.10 that > > have the changlog partition map from checkpoint to the coordinator stream. > > I would propose to remove the migration code completely.
Yes. I think we should remove this code ! +1 for that :) - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50318/#review143283 ----------------------------------------------------------- On July 22, 2016, 1:24 a.m., Xinyu Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50318/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 1:24 a.m.) > > > Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > After the thread-safe kafka producer change, all producer need to register > the source before publishing to it. The registering of > KafkaCheckpointMigration happens in the wrong place. Move it after the > producer is created. > > Also find an extra logging introduced by the change. Remove it during this > fix. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala > 7245902c69c751a4e8853745de46adf5553d45f5 > > samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala > 5d2641ab1e54d49f7b983bc526762cfb50f2911b > > Diff: https://reviews.apache.org/r/50318/diff/ > > > Testing > ------- > > Tested by locally deployed jobs. > > Passed gradle tests. > > > Thanks, > > Xinyu Liu > >
