----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48808/#review138626 -----------------------------------------------------------
lgtm. There is an issue in this patch w/ broadcast stream in general. It would be good to address it if we are going to include this in the open source release. docs/learn/documentation/versioned/jobs/configuration-table.html (line 260) <https://reviews.apache.org/r/48808/#comment203820> Should be calling out to be used together w/ ProcessJobFactory and ThreadJobFactory only. samza-core/src/main/scala/org/apache/samza/system/RangeSystemStreamPartitionMatcher.scala (line 52) <https://reviews.apache.org/r/48808/#comment203823> This has some issue w/ broadcast stream: it can potentially filter out the broadcast stream. We need to at least document it. Ideally, the broadcast streams should escape the ssp matchers since they should be assigned to all containers. samza-core/src/main/scala/org/apache/samza/system/RegexSystemStreamPartitionMatcher.scala (line 33) <https://reviews.apache.org/r/48808/#comment203825> The same thing here. We need to at least document that usage of ssp matcher and broadcast stream together could be an issue. - Yi Pan (Data Infrastructure) On June 16, 2016, 6:40 p.m., Jagadish Venkatraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48808/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 6:40 p.m.) > > > Review request for samza and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > Rebase samza-41 with master > > > Diffs > ----- > > docs/learn/documentation/versioned/jobs/configuration-table.html > c1c822e03ce960c69b07eb44409a9af018823ef6 > > samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionMatcher.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala > 23a51b2175506d9e0dbbf7675d3b8061f2aacbe3 > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala > e9a51083aff4dc316e94144f6242fe702ca73a68 > > samza-core/src/main/scala/org/apache/samza/system/RangeSystemStreamPartitionMatcher.scala > PRE-CREATION > > samza-core/src/main/scala/org/apache/samza/system/RegexSystemStreamPartitionMatcher.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala > 55a879be9e6792a60ff685fbdc5411c197243ed0 > > samza-core/src/test/scala/org/apache/samza/system/TestRangeSystemStreamPartitionMatcher.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/system/TestRegexSystemStreamPartitionMatcher.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/48808/diff/ > > > Testing > ------- > > > Thanks, > > Jagadish Venkatraman > >
