----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48862/#review138282 -----------------------------------------------------------
Ship it! Ship It! - Yi Pan (Data Infrastructure) On June 17, 2016, 6:20 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48862/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 6:20 p.m.) > > > Review request for samza and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-969 > https://issues.apache.org/jira/browse/SAMZA-969 > > > Repository: samza > > > Description > ------- > > allow empty serde for SystemStream and System > by using getNonEmptyOption() for serde > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/config/ScalaMapConfig.scala > 5fb1f52e813672162a8a12ef82231294b05d0c0a > samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala > e172589e075852c0163a40e65e26038f682ecc17 > samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala > bf974df349b0d8dfef8f6d8977ef95318af28583 > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 086531e4d72e88d21735db6a5afd1c7e84b6c2e5 > samza-core/src/main/scala/org/apache/samza/util/Util.scala > fc3d085d7fff9f7dcec766ba48e550eb0052e99d > > Diff: https://reviews.apache.org/r/48862/diff/ > > > Testing > ------- > > Manual. > > > Thanks, > > Boris Shkolnik > >