----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48215/#review136337 -----------------------------------------------------------
Ship it! lgtm. Thanks for rebasing! - Jagadish Venkatraman On June 3, 2016, 6:13 p.m., Yi Pan (Data Infrastructure) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48215/ > ----------------------------------------------------------- > > (Updated June 3, 2016, 6:13 p.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, and Xinyu Liu. > > > Bugs: SAMZA-727 > https://issues.apache.org/jira/browse/SAMZA-727 > > > Repository: samza > > > Description > ------- > > SAMZA-727: Support for Kerberos > > > Diffs > ----- > > build.gradle 16facbbf4dff378c561461786ff186bd9e0000ed > samza-core/src/main/java/org/apache/samza/container/SecurityManager.java > PRE-CREATION > > samza-core/src/main/java/org/apache/samza/container/SecurityManagerFactory.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala > 4d5ca4d3d2dd1542c5d073dfe6c13666ef5f51fc > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > cf3c4c0ab08a59760bc899c6f2027755e933b350 > samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java > c556d833059826d97ad6928de47330effba40219 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala > 74a067617c5dd868c2a017d615c35a2f74f300fd > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala > 7bd813159745b105cd31c8e19f1352280acf9da5 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala > 3adf86f83123f6d66fc18ef9feed95b551c8398f > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaContainerSecurityManager.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecurityManagerFactory.scala > PRE-CREATION > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala > 62ddb261f0b8f0f24468875d6d84da05908a3c62 > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestClientHelper.scala > PRE-CREATION > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala > fc0091f3f3ba0b2e7cd6bbd4e279b71087fb326b > > Diff: https://reviews.apache.org/r/48215/diff/ > > > Testing > ------- > > local build passed. > > Pending for real test in secured YARN cluster. > > > Thanks, > > Yi Pan (Data Infrastructure) > >