----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48109/#review135803 -----------------------------------------------------------
Ship it! samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala (line 173) <https://reviews.apache.org/r/48109/#comment200849> I think you could even get away with returning true here only if the key is an array and we're already doing the check earlier. That would also allow the hasArrayKeys method to be dropped along with the containsArrayKeys field, which would later need to be guarded by a lock or made volatile. This would be an improvement but is tangential to your change. It would be fine to bias towards safety in doubt. - Chris Pettitt On June 1, 2016, 2:23 a.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48109/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 2:23 a.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-957 > https://issues.apache.org/jira/browse/SAMZA-957 > > > Repository: samza > > > Description > ------- > > SAMZA-957 Avoid unnecessary KV Store flushes (part 3) > > > Diffs > ----- > > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala > c28f8db8cb59bd5415e78535877acc1e5bee0f67 > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala > eee74473726cb2a36d0b75fe5c9df737440980bc > > Diff: https://reviews.apache.org/r/48109/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Jake Maes > >
