----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46952/#review131633 -----------------------------------------------------------
Ship it! Thanks for addressing the nits. LGTM. Ship It! - Jagadish Venkatraman On May 4, 2016, 3:34 a.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46952/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 3:34 a.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Navina Ramesh, > Jagadish Venkatraman, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-944 > https://issues.apache.org/jira/browse/SAMZA-944 > > > Repository: samza > > > Description > ------- > > SAMZA-944 Broadcast stream is not added properly in the prioritized tiers in > the DefaultChooser > > * DefaultChooserConfig has been converted to Java. It also now takes ALL > input streams (including broadcast streams) into account when returning > bootstrap and prioritized streams > * TaskConfigJava - getBroadcastSystemStreamPartitions can now be called even > if there are no configured broadcast streams. It also has a new method to > return ALL input systems, including broadcast streams. > * DefaultChooser.java - only changed to handle conversion between java/scala > data structures, sigh > > > Diffs > ----- > > checkstyle/import-control.xml c15b8e74de8e5aac5ac83278c52ab3dba1630e50 > samza-core/src/main/java/org/apache/samza/config/DefaultChooserConfig.java > PRE-CREATION > samza-core/src/main/java/org/apache/samza/config/TaskConfigJava.java > 8acb6ca1cd220e715272d254398545ce487c0ff7 > > samza-core/src/main/scala/org/apache/samza/config/DefaultChooserConfig.scala > 422439355565616d7b629f2fcbc9207d709ef78c > > samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala > 95bd18898dd9e2b6848523fe89c9017a7267ab3b > > samza-core/src/test/scala/org/apache/samza/system/chooser/TestDefaultChooser.scala > 090995653a6314e081f14729ea092d61e89c1a86 > > Diff: https://reviews.apache.org/r/46952/diff/ > > > Testing > ------- > > 2 new unit tests and ran check_all.sh > > > Thanks, > > Jake Maes > >
