----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44418/#review125141 -----------------------------------------------------------
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java (line 176) <https://reviews.apache.org/r/44418/#comment187903> jobModelRef is an AtomicReference. Initial value is null, unless the JobCoordinator is instantiated. can you add a test to verify that this will not result in an NPE? Also, it will be useful to run hello-samza with StreamAppender and verify that the functionality is not broken. - Navina Ramesh On March 5, 2016, 7:08 a.m., Tao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44418/ > ----------------------------------------------------------- > > (Updated March 5, 2016, 7:08 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-877: Use cached JobModel everywhere in the Samza AM container > > > Diffs > ----- > > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java > 0c6329ede9b3df4dc05125729b5b44ba2c98803a > > Diff: https://reviews.apache.org/r/44418/diff/ > > > Testing > ------- > > ./gradlew clean build && ./gradlew checkstyleMain checkstyleTest > > > Thanks, > > Tao Feng > >
