----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43766/#review119937 -----------------------------------------------------------
docs/learn/documentation/versioned/jobs/logging.md (line 65) <https://reviews.apache.org/r/43766/#comment181328> Really appreciate the contribution to the doc. minor typos. I'd prefer to re-word this as - "For example, you can use a rolling appender to rotate the log once it reaches a certain size by configuring log4j.xml like this: " - Jagadish Venkatraman On Feb. 19, 2016, 2:48 p.m., Branislav Cogic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43766/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 2:48 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-872 > https://issues.apache.org/jira/browse/SAMZA-872 > > > Repository: samza > > > Description > ------- > > Changed docs for Logging: DailyRollingFileAppender removed with > RollingFileAppender > > > Diffs > ----- > > docs/learn/documentation/versioned/jobs/logging.md > caca43f9c3f4c630365decd425e375afe8b09355 > > Diff: https://reviews.apache.org/r/43766/diff/ > > > Testing > ------- > > > Thanks, > > Branislav Cogic > >
