----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41884/#review113037 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala (line 55) <https://reviews.apache.org/r/41884/#comment173532> I do not see how oldestOffsets could ever be null here: it is either an immutable.Map created on line 183 or set to the sum/union of two immutable.Maps on 193. They can never be null. By the way: - The modification on line 210 has no effect (as it is not reassigned to the oldestOffsets variable) - line 212 only compiles because of the import of JavaConversions on line 33. Here the immutable oldestOffset Map gets converted to a java.util.Map (because the immutable Map does not have the put method) but if that code actually got executed it would throw an UnsupportedOperationException.... - Bruno De Bus On Jan. 4, 2016, 12:59 p.m., Aleksandar Pejakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41884/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 12:59 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Quick fix to prevent NullPointerException. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala > 9dc436a > > Diff: https://reviews.apache.org/r/41884/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandar Pejakovic > >
