----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40407/#review107095 -----------------------------------------------------------
Overall looks good. It would be nice to add some unit test as well. Thanks! samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala (line 628) <https://reviews.apache.org/r/40407/#comment166018> Is there any use case for each individual store's restoring time? It may be useful. samza-yarn/src/main/java/org/apache/samza/job/yarn/HostAwareContainerAllocator.java (line 79) <https://reviews.apache.org/r/40407/#comment166020> If this is the only place to call the runContainer() w/ additional argument and requestMatched is always true here, maybe we should change the method name to runMatchedContainer() in ContainerUtil, which does: {code} public void runMatchedContainer(int samzaContainerId, Container container) { state.matchedContainerRequests.incrementAndGet(); runContainer(samzaContainerId, container); } {code} - Yi Pan (Data Infrastructure) On Nov. 17, 2015, 10:01 p.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40407/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 10:01 p.m.) > > > Review request for samza, Yan Fang, Jake Maes, Jagadish Venkatraman, Xinyu > Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-817 > https://issues.apache.org/jira/browse/SAMZA-817 > > > Repository: samza > > > Description > ------- > > Adding ratio of successful locality matched request as a gauge > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 3787b85e5cc738d16c0d1eaea4de3345a3a9106c > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > 127f3a141f25930281ef3c64b314a7b5b79dfade > > samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContainerAllocator.java > 6edd47717ff10fbf10ce52b401b8ce093c59930e > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java > 55dbfeac44834f9899b473318fb7dcefe7a59bc3 > > samza-yarn/src/main/java/org/apache/samza/job/yarn/HostAwareContainerAllocator.java > ad1587d6e00b7145bbe752047fcd9046c7b1b73e > samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaAppState.java > 3df927e5dfd056b00a77f86aaba49585264115ae > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > ae5a674f1c29e1d05be17a037dbe38b033a45145 > > Diff: https://reviews.apache.org/r/40407/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Navina Ramesh > >
