----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38832/#review100989 -----------------------------------------------------------
Ship it! samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java <https://reviews.apache.org/r/38832/#comment158288> This was added for debugging. Thanks for noticing it! - Navina Ramesh On Sept. 29, 2015, 12:18 a.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38832/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 12:18 a.m.) > > > Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure). > > > Repository: samza > > > Description > ------- > > Remove the dependency on JUnit, which shouldn't be in production code and in > some environments, could be explicitly excluded and cause build errors. > > Interestingly, gradle allowed the dependency even though we only ever add > JUnit as a testCompile dependency. It looks like this is due to a transitive > dependency. > > > Diffs > ----- > > samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java > c2a9ac0740101ce9dc73f80220dc6ec828407409 > > Diff: https://reviews.apache.org/r/38832/diff/ > > > Testing > ------- > > > Thanks, > > Jake Maes > >
