----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37069/#review95692 -----------------------------------------------------------
Ship it! LGTM. - Yi Pan (Data Infrastructure) On Aug. 5, 2015, 2:58 p.m., Aleksandar Pejakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37069/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 2:58 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Changed SystemProducersMetrics and RunLoop so that metrics now show > nanoseconds instead milliseconds. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae4 > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > aa7a9bc > samza-core/src/main/scala/org/apache/samza/util/TimerUtils.scala 1643070 > samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala > 64a5844 > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala > 39c54aa > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducerMetrics.scala > 8aa73ce > > Diff: https://reviews.apache.org/r/37069/diff/ > > > Testing > ------- > > Tested on hello-samza -> wikipedia-parser, results: > ``` > "org.apache.samza.container.SamzaContainerMetrics":{ > "commit-calls":10, > "window-ns":3198.62544796632, > "process-null-envelopes":56292, > "process-envelopes":989, > "window-calls":0, > "commit-ns":5130.901534393375, > "send-calls":0, > "process-calls":57283, > "choose-ns":10368839.818551894, > "process-ns":10390588.194071393, > "event-loop-utilization":0.99807554 > } > ``` > > > Thanks, > > Aleksandar Pejakovic > >
