> On June 8, 2015, 2:29 a.m., Navina Ramesh wrote: > > samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala, line > > 182 > > <https://reviews.apache.org/r/35067/diff/1/?file=979072#file979072line182> > > > > This warning is valid only when the configured value for > > max.in.flight.requests.per.connection > 1. Can you check the value and make > > the comment more elaborate? > > Robert Zuljevic wrote: > Hi. In order to do that I would need to cast the string to integer which > can throw an NumberFormatException. Is this ok?
Yeah. I understand your concern here. I think config validation is not yet standardized in the codebase. I think this should be fixed when we address SAMZA-471 - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35067/#review86980 ----------------------------------------------------------- On June 15, 2015, 1:42 p.m., Robert Zuljevic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35067/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 1:42 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fixed test > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala > a1de88781a8ff2a3fe50389ae7a59062289404fc > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 82006960adc45a92a79e28f078ebd5eb01d3205e > > Diff: https://reviews.apache.org/r/35067/diff/ > > > Testing > ------- > > > Thanks, > > Robert Zuljevic > >
