----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34585/#review86531 -----------------------------------------------------------
Overall, looks good. I like the idea of a unit test harness, though I am wondering how frequently developers (Samza users) will need to test the tasks they write. samza-test/src/main/java/org/apache/samza/test/harness/SimpleIncomingMessageEnvelope.java <https://reviews.apache.org/r/34585/#comment139856> Can you make this class final? samza-test/src/main/java/org/apache/samza/test/harness/SimpleOutgoingMessageEnvelope.java <https://reviews.apache.org/r/34585/#comment139858> Can you make this class final? samza-test/src/main/java/org/apache/samza/test/harness/TaskUnitTestHarness.java <https://reviews.apache.org/r/34585/#comment139868> Is there going to be concurrent access ?? Feel like I am missing something here. samza-test/src/test/java/org/apache/samza/test/harness/InMemoryTaskContextTest.java <https://reviews.apache.org/r/34585/#comment138584> can you correct this to org.apache.samza.test.harness.<ClassName> ? samza-test/src/test/java/org/apache/samza/test/harness/InMemoryTaskContextTest.java <https://reviews.apache.org/r/34585/#comment138585> Same here - Navina Ramesh On May 22, 2015, 5:23 a.m., Luis De Pombo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34585/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 5:23 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-681: create a unit test harness to easily test samza tasks > > > Diffs > ----- > > checkstyle/import-control.xml 5f8e103a2e43f96518b20de1c7cbd84e0af24842 > > samza-test/src/main/java/org/apache/samza/test/harness/InMemoryMessageCollector.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/test/harness/InMemoryTaskContext.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/test/harness/MessageCollectorListener.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/test/harness/SimpleIncomingMessageEnvelope.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/test/harness/SimpleOutgoingMessageEnvelope.java > PRE-CREATION > > samza-test/src/main/java/org/apache/samza/test/harness/TaskUnitTestHarness.java > PRE-CREATION > > samza-test/src/test/java/org/apache/samza/test/harness/InMemoryMessageCollectorTest.java > PRE-CREATION > > samza-test/src/test/java/org/apache/samza/test/harness/InMemoryTaskContextTest.java > PRE-CREATION > > samza-test/src/test/java/org/apache/samza/test/harness/SimpleMessageEnvelopeTest.java > PRE-CREATION > > samza-test/src/test/java/org/apache/samza/test/harness/TaskUnitTestHarnessTest.java > PRE-CREATION > samza-test/src/test/java/org/apache/samza/test/harness/TestProcessTask.java > PRE-CREATION > samza-test/src/test/java/org/apache/samza/test/harness/TestWindowTask.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34585/diff/ > > > Testing > ------- > > > Thanks, > > Luis De Pombo > >
