----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34626/#review85155 -----------------------------------------------------------
Ship it! LGTM. Thanks! - Yi Pan (Data Infrastructure) On May 23, 2015, 6:17 a.m., Jose Barrueta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34626/ > ----------------------------------------------------------- > > (Updated May 23, 2015, 6:17 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Adding 'fs.https.impl=org.apache.samza.util.hadoop.HttpFileSystem' to the > YarnConfiguration used to create a YarnJob. For backwards compatibility this > patch just added the new supported 'https' filesystems instead of going > through major refactoring of the YarnJobFactory. > > > Diffs > ----- > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJobFactory.scala > a5135671981030acaa07d9392d8d46f31fe9bb85 > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestYarnJobFactory.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/34626/diff/ > > > Testing > ------- > > > Thanks, > > Jose Barrueta > >
