----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34564/#review84886 -----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala <https://reviews.apache.org/r/34564/#comment136333> can we nest the code as it is? It looks cleaner. I think like updateTimer, a similar method which returns the elapsed time, or a method that accepts and updates the activeMs inside the method. samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala <https://reviews.apache.org/r/34564/#comment136334> do we want to create a new Gauge every loop? I think one Gauge is sufficient, we can update its value. What do you think? - Yan Fang On May 21, 2015, 8:53 p.m., Luis De Pombo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34564/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 8:53 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-401: add utilization metrics for the event loop > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala > 4c0faf61c591771a05f233f311d7eb4524ac01ff > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > 7d9ff0040ff75a49e21d26d28d8940e5328fb2c5 > samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala > 73ec2b5a7c1ca17fbb80604355881bff51f7e41e > > Diff: https://reviews.apache.org/r/34564/diff/ > > > Testing > ------- > > > Thanks, > > Luis De Pombo > >
