----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/#review82777 -----------------------------------------------------------
Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 6, 2015, 11:38 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33761/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 11:38 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-658 > https://issues.apache.org/jira/browse/SAMZA-658 > > > Repository: samza > > > Description > ------- > > Address Yi's comments round two > > > Diffs > ----- > > > samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala > 217333c84c696c0cc1bc3eeabf1c4066a6e89795 > > samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala > b3624e6057ee1a86090f00d2853035b06f63358d > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala > 61bb3f6acb080b653f8b11176538549738255acc > > samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala > 3a23daf053f0b8dec3a7ec83a51c9c5527078a3b > samza-kv/src/test/scala/org/apache/samza/storage/kv/MockKeyValueStore.scala > PRE-CREATION > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala > d03ec925b103ccf3c1561de0461fbc39cbe9d9ca > > Diff: https://reviews.apache.org/r/33761/diff/ > > > Testing > ------- > > unit tests > > > Thanks, > > Guozhang Wang > >
