> On April 29, 2015, 1:06 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 119 > > <https://reviews.apache.org/r/33674/diff/1/?file=945326#file945326line119> > > > > This "config" is not used anymore. remove it?
Oops, I missed that. - Tommy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33674/#review81978 ----------------------------------------------------------- On April 29, 2015, 2:28 p.m., Tommy Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33674/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 2:28 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fix SAMZA-660 - Default serdes do not work for changelog streams. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 56819e0 > > samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala > 58d7fe8 > > Diff: https://reviews.apache.org/r/33674/diff/ > > > Testing > ------- > > Unit tested; had trouble running master due to some issue with the > CoordinatorStream commit. > > > Thanks, > > Tommy Becker > >
