----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33503/#review81506 -----------------------------------------------------------
README-gradle.txt <https://reviews.apache.org/r/33503/#comment131904> "build hello-samza job package" sounds better because actually "./gradlw build" is for "build hello-samza project", not "distTar". README-gradle.txt <https://reviews.apache.org/r/33503/#comment131911> start grid sounds better build.gradle <https://reviews.apache.org/r/33503/#comment131907> can we use installGrid ? build.gradle <https://reviews.apache.org/r/33503/#comment131909> use installSamza or deploySamza ? build.gradle <https://reviews.apache.org/r/33503/#comment131891> can we use startGrid here to be consistent with "stopGrid" ? build.gradle <https://reviews.apache.org/r/33503/#comment131892> name to listKafkaTopics? gradle/wrapper/gradle-wrapper.properties <https://reviews.apache.org/r/33503/#comment131895> downloading binary is sufficient, which is smaller in terms of the size. - Yan Fang On April 24, 2015, 2:40 a.m., Ken Gidley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33503/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 2:40 a.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > Create build.gradle, gradle.properties, and README-gradle.txt files for > hello-samza. > Update pom.xml to exclude gradle related files and build artifacts from RAT > license > checks when using Maven. > > Update to 0.9.0 Samza, 0.8.2.1 Kafka > > Rebase to latest ‘hello-samza’, with 0.9.0 Samza and 0.8.2.1 Kafka. > Remove unneeded dependency on old serializers. > > > Diffs > ----- > > .gitignore 0435c14b334fef6a7dd0e401195e9cce88f60a4a > README-gradle.txt PRE-CREATION > build.gradle PRE-CREATION > gradle.properties PRE-CREATION > gradle/wrapper/gradle-wrapper.jar PRE-CREATION > gradle/wrapper/gradle-wrapper.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > pom.xml b4ea5613e520fa94f635426a469d496c69efc9ac > > Diff: https://reviews.apache.org/r/33503/diff/ > > > Testing > ------- > > Local build/testing done on Mac, with Java 1.7. > > > Thanks, > > Ken Gidley > >
