----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32155/#review76944 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala <https://reviews.apache.org/r/32155/#comment124665> Can you explain the purpose of "failedSources"? samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala <https://reviews.apache.org/r/32155/#comment124666> Why can't you do the failedSources empty check here instead of Line 153 ? - Navina Ramesh On March 17, 2015, 9:37 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32155/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 9:37 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-458 > https://issues.apache.org/jira/browse/SAMZA-458 > > > Repository: samza > > > Description > ------- > > add flush in close method > only throw exceptions after flushing all sources > add unit test > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala > 83668dd > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala > ca10ea5 > > Diff: https://reviews.apache.org/r/32155/diff/ > > > Testing > ------- > > ran unit tests and integration test > > > Thanks, > > Yan Fang > >
