----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30667/#review71295 -----------------------------------------------------------
samza-sql/src/main/java/org/apache/samza/sql/api/data/Data.java <https://reviews.apache.org/r/30667/#comment116963> I don't know how byte-arrays are handled elsewhere in Samza but consider making this return a ByteString (directly analogous to String but contains bytes rather than chars). It is immutable so you don't have to worry about sharing values. - Julian Hyde On Feb. 5, 2015, 4:07 p.m., Milinda Pathirage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30667/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 4:07 p.m.) > > > Review request for samza, Chris Riccomini, Julian Hyde, and Yi Pan (Data > Infrastructure). > > > Repository: samza > > > Description > ------- > > # Samza Calcite Integration Prototype > > - Supports simple stream query planning based on Calcite's 'chi' branch > (https://github.com/julianhyde/incubator-calcite/tree/chi) with STREAM > support. > - No query planning customizations specific to Samza yet. > - Calcite integration related code can be found under package > 'org.apache.samza.sql.compiler' > > ## Next Steps > > - Implement a compiler which converts query plan generated by Calcite to a > set of Samza Jobs > - Integrate the Calcite query optimizer > > > Diffs > ----- > > build.gradle 4d0b44f > gradle/dependency-versions.gradle 12b324d > samza-sql/README PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/data/Data.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/data/EntityName.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/data/Relation.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/data/Schema.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/data/Tuple.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/operators/Operator.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/api/operators/RelationOperator.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/api/operators/SqlOperatorFactory.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/api/operators/TupleOperator.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/api/operators/spec/OperatorSpec.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/api/router/OperatorRouter.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/compiler/SamzaCalciteConnection.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/compiler/SamzaPreparingStmt.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/compiler/SamzaQueryPreparator.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/compiler/SamzaSqlValidator.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/data/avro/AvroData.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/data/avro/AvroSchema.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerde.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlStringSerdeFactory.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/data/string/StringData.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/data/string/StringSchema.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperator.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/operators/relation/Join.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/relation/JoinSpec.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/stream/InsertStream.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/stream/InsertStreamSpec.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/operators/window/WindowState.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/sql/router/SimpleRouter.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/sql/task/StoreMessageCollector.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/task/sql/OperatorMessageCollector.java > PRE-CREATION > samza-sql/src/main/java/org/apache/samza/task/sql/SqlMessageCollector.java > PRE-CREATION > > samza-sql/src/main/java/org/apache/samza/task/sql/StoreMessageCollector.java > PRE-CREATION > samza-sql/src/test/java/org/apache/samza/sql/compiler/PrepareQueryTest.java > PRE-CREATION > > samza-sql/src/test/java/org/apache/samza/sql/compiler/SamzaStreamTableFactory.java > PRE-CREATION > samza-sql/src/test/java/org/apache/samza/sql/task/RandomOperatorTask.java > PRE-CREATION > samza-sql/src/test/java/org/apache/samza/task/sql/RandomOperatorTask.java > PRE-CREATION > samza-sql/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java > PRE-CREATION > settings.gradle bb07a3b > > Diff: https://reviews.apache.org/r/30667/diff/ > > > Testing > ------- > > > Thanks, > > Milinda Pathirage > >