Hi Josh, I'm sorry for the delay. It looks like in our application everything looks fine.
Thanks Harbs for tip with ignorecoercion - it helps. :) Thanks, Piotr sob., 12 paź 2024 o 01:06 Maria Jose Esteve <mjest...@iest.com> napisał(a): > Switching to 0.9.12-SNAPSHOT and a small tweak to a component. > I compile the SDK with ant and Maven and my projects with Maven. > Everything compiled OK: debug and release > > Hiedra > > -----Mensaje original----- > De: Maria Jose Esteve <mjest...@iest.com> > Enviado el: viernes, 11 de octubre de 2024 20:46 > Para: dev@royale.apache.org > Asunto: RE: Super method calls not currently checked for errors > > Hi, I'll also test my applications. It will also be a good test bench for > programmers who have more difficulty programming 😝 > > Hiedra > > -----Mensaje original----- > De: Harbs <harbs.li...@gmail.com> > Enviado el: viernes, 11 de octubre de 2024 9:53 > Para: Apache Royale Development <dev@royale.apache.org> > Asunto: Re: Super method calls not currently checked for errors > > I’ll test this against my apps next week. > > I’m on the fence about whether we should push it into the current release. > > > On Oct 9, 2024, at 11:53 PM, Josh Tynjala <joshtynj...@bowlerhat.dev> > wrote: > > > > I too tend to be extra wary to make changes close to a release. > > Sometimes, even seemingly minor bug fixes can introduce unexpected side > effects! > > > > I totally don't mind waiting to merge this stuff. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Oct 9, 2024 at 11:20 AM Andrew Wetmore <cottag...@gmail.com> > wrote: > > > >> I am always scared of putting a major, necessary fix that might have > >> downstream impact into a release that is about to go out the door. I > >> would vote for making this part, perhaps the major part, of the next > >> release, and using the time between this one and that one to find and > >> fix as much as we can in our own code...and maybe prepare some > >> examples with fixes to help Royale users. > >> > >> On Wed, Oct 9, 2024 at 2:11 PM Josh Tynjala > >> <joshtynj...@bowlerhat.dev> > >> wrote: > >> > >>> Hey all, > >>> > >>> A user of vscode-as3mxml pointed out to me recently that the > >>> arguments passed to super() and super.method() calls are not > >>> currently checked for errors by our compiler. That includes checking > >>> the types of the > >> arguments, > >>> and even whether the number of arguments is actually correct! > >>> However, regular function calls without super are correctly type > >>> checked, so it is only in cases of inheritance where super is used. > >>> > >>> I have royale-compiler fixes ready to go. > >>> > >>> This bug has been in the compiler since the code was donated by > >>> Adobe. So it's definitely not even remotely new, and it doesn't > >>> necessarily need to delay the current release in progress. > >>> > >>> However, it may impact a lot of existing code once the compiler can > >>> start detecting the wrong types. Several of our framework libraries > >>> in royale-asjs are affected. It's likely that user projects, > >>> especially ones with a lot of inheritance, will be affected too. > >>> > >>> In some cases, it just requires an extra cast. However, in a few > >>> cases > >> that > >>> I've seen so far, it is actually showing that there are bugs in our > code. > >>> I'm working through the necessary fixes in royale-asjs now. > >>> > >>> I just wanted to give a heads up about this, as it may have some > >>> impact > >> on > >>> everyone's projects. > >>> > >>> Any thoughts on pushing this into the 0.9.12? Or would you rather > >>> wait > >> for > >>> the next one? > >>> > >>> -- > >>> Josh Tynjala > >>> Bowler Hat LLC <https://bowlerhat.dev> > >>> > >> > >> > >> -- > >> Andrew Wetmore > >> > >> Editor, Moose House Publications <https://moosehousepress.com/> > >> Editor-Writer, The Apache Software Foundation <https://apache.org/> > >> > > -- Piotr Zarzycki
