I might be wrong, but I think from memory, there were some issues upgrading because of the current state of support for runtime module loading, and some changes in the GC classes that were subclassed in royale compiler code. I think this was a blocker for easy upgrade in the past when I tried, but it was some time back, so not 100% sure...
On Wed, 29 Nov 2023, 6:24 am Josh Tynjala, <joshtynj...@bowlerhat.dev> wrote: > It could be as easy as updating the version number, and everything still > works the same from our end. Or they could have breaking changes in the > Closure Compiler APIs, or maybe they've started requiring JS to be written > in a different way, and then things could be very complicated. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Nov 28, 2023 at 9:07 AM Gabe Harbs <harbs.li...@gmail.com> wrote: > > > I guess I’ll try. > > > > And IIRC, updating Closure Compiler was very complicated. Right? > > > > > On Nov 28, 2023, at 6:46 PM, Josh Tynjala <joshtynj...@bowlerhat.dev> > > wrote: > > > > > > You can set the GOOG_HOME environment variable (or env.GOOG_HOME in > > > env.properties) to use a custom Closure Library when building > > royale-asjs, > > > instead of the version that we have pinned. > > > > > > I seem to remember Alex mentioning that updating either Closure > Compiler > > or > > > Closure Library *sometimes* also requires updating the other. I don't > see > > > any mention of specific versions in either README file, though. So you > > > might just need to try using an updated Closure Library and test if it > > > works with the version of Closure Compiler that we're bundling. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > On Tue, Nov 28, 2023 at 8:34 AM Gabe Harbs <harbs.li...@gmail.com> > > wrote: > > > > > >> It seems like our dependency of Closure Compiler is too old. > > >> > > >> I have an app which runs inside Google Workspace and I’m having issues > > >> running a debug version since Google enabled TrustedHTML restrictions. > > >> https://developer.mozilla.org/en-US/docs/Web/API/TrustedHTML > > >> > > >> The newer versions appear to support TrustedHTML. > > >> > > >> > > >> > > > https://github.com/google/closure-library/blob/7818ff7dc0b53555a7fb3c3427e6761e88bde3a2/closure/goog/base.js#L2996 > > >> > > >> Is there an issue with just swapping the closure-library version? > > >> > > >> Harbs > > > > >
