I ran into two separate issues with the approval script. The first issue was the ASDoc example build failing in the JS-only SDK, which I discovered was happening because I didn't realize that I had an AIR_HOME environment variable set externally. I cleared AIR_HOME, and that's fixed it for me. No RC needed for this.
The second issue was the MenuExample example build failing. My commit today fixes that. A new RC is needed to resolve this one with my commit. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Mar 15, 2022 at 1:52 PM Yishay Weiss <yishayj...@hotmail.com> wrote: > I’m not following. Was the problem AIR_HOME or what your latest commit > fixed? Do we need another RC? > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Tuesday, March 15, 2022 10:01 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC3 > > I discovered that I had an AIR_HOME environment variable set elsewhere, and > that was causing the ASDoc build failure. In the approval script, I can now > reach MenuExample with both use-flash and without. > > I pushed a commit to develop that fixes the MenuExample build issue. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Mar 15, 2022 at 10:37 AM Josh Tynjala <joshtynj...@bowlerhat.dev> > wrote: > > > When running the approval script *without* -Duse-flash=true (in other > > words, JS-only), I get the following error when it tries to build the > ASDoc > > example. However, it seems to build that example correctly when I use > > -Duse-flash=true. > > > > json: > > ROYALE_COMPILER_HOME: > > > /Users/joshtynjala/Desktop/ApacheRoyale/apache-royale-0.9.9-src/royale-asjs/js > > 16.6482905 seconds > > java.lang.NullPointerException: Cannot invoke > > "org.apache.royale.compiler.tree.as.IASNode.getSourcePath()" because > "node" > > is null > > org.apache.royale.compiler.internal.codegen.as > .ASBlockWalker.walk(ASBlockWalker.java:163)org.apache.royale.compiler. > internal.codegen.as > .ASBlockWalker.visitCompilationUnit(ASBlockWalker.java:188)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:96)org.apache.royale.compiler.internal.codegen.js.JSWriter.writeTo(JSWriter.java:80)org.apache.royale.compiler.clients.ASDOCJSC.compile(ASDOCJSC.java:275)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:264)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:221)org.apache.royale.compiler.clients.ASDOCJSC.staticMainNoExit(ASDOCJSC.java:159)org.apache.royale.compiler.clients.ASDOCJSC.main(ASDOCJSC.java:107) > > > > With -Duse-flash=true, I was able to get ASDoc built, but it fails on > > building MenuExample later. This is the error: > > > > > apache-royale-0.9.9-src/royale-asjs/examples/royale/MenuExample/src/main/royale/MenuExample.mxml(34): > > col: 3 Error: This tag could not be resolved to an ActionScript class. It > > will be ignored. > > > > <royale:MyInitialView /> > > > > The issue seems to be caused by this commit: > > > > > > > https://github.com/apache/royale-asjs/commit/8bfe4a96a37a3a45441793694a9893bbd5f50d4f > > > > The source path should not have been changed from src/main/royale to src. > > The correct source path is src/main/royale for all examples and libraries > > in Royale. > > > > I will see if I can get these issues fixed for the next RC. As things > > are right now, I would vote -1. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Sun, Mar 13, 2022 at 11:35 PM <apacheroyal...@gmail.com> wrote: > > > >> This is the discussion thread. > >> > >> Thanks, > >> Yishay Weiss > > > > > >
