Good news! Thanks for figuring it out. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Aug 17, 2021 at 5:22 AM Yishay Weiss <yishayj...@hotmail.com> wrote: > This is fixed now. I made sure GOOG_HOME was pointing to > …\royale-asjs\js\lib\google\closure-library. Either the previous GOOG_HOME > was invalid or it wasn’t set (didn’t check). > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Monday, July 26, 2021 9:31 PM > To: Yishay Weiss<mailto:yishayj...@hotmail.com> > Cc: Apache Royale Development<mailto:dev@royale.apache.org> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC5 > > I've tried to figure out why the compiler integration tests are failing on > Jenkins, but I can't seem to reproduce locally. I tried a few combinations > of env vars with no luck. They always pass on my computer. > > -- > Josh Tynjala > Bowler Hat LLC<https://bowlerhat.dev> > > > On Mon, Jul 26, 2021 at 11:25 AM Yishay Weiss <yishayj...@hotmail.com > <mailto:yishayj...@hotmail.com>> wrote: > Thanks, yes, I did miss that comment. Good thing we have a release so we > can’t ignore these things. I’ll fix per your observations > > I have also noticed royale-compiler-integration tests and > royale-asjs_MXTests are failing on Jenkins so it might not make sense to > cut a release before fixing those anyway. I am not sure how much time I’ll > have to look at those in the coming days so if anyone wants to beat me to > it all the better. > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Monday, July 26, 2021 7:58 PM > To: Apache Royale Development<mailto:dev@royale.apache.org> > Cc: Yishay Weiss<mailto:yishayj...@hotmail.com> > Subject: Re: [DISCUSS] Discuss Release Apache Royale 0.9.8 RC5 > > I should add that I don't get a stack trace. Compiling the example fails > with regular compiler errors. > > Here are a couple example errors that I see: > > /Users/joshtynjala/Desktop/royale/apache-royale-0.9.8-src/royale-asjs/frameworks/projects/SparkRoyale/src/main/royale/spark/filters/BevelFilter.as(23): > col: 8 Definition flash.filters.BevelFilter could not be found. > > import flash.filters.BevelFilter; > ^ > > /Users/joshtynjala/Desktop/royale/apache-royale-0.9.8-src/royale-asjs/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/spark/ScrollBarDownButtonSkin.mxml(32): > col: 1 This tag could not be resolved to an ActionScript class. It will be > ignored. > > <s:SparkSkin xmlns:fx="http://ns.adobe.com/mxml/2009"; xmlns:s="library:// > ns.adobe.com/flex/spark<http://ns.adobe.com/flex/spark>" > ^ > > It looks like some code needs COMPILE:SWF, and some code is using the > wrong MXML namespace. There might be more issues, but those are the obvious > first ones I see. > > -- > Josh Tynjala > Bowler Hat LLC<https://bowlerhat.dev> > > > On Mon, Jul 26, 2021 at 9:54 AM Josh Tynjala <joshtynj...@bowlerhat.dev > <mailto:joshtynj...@bowlerhat.dev>> wrote: > The approval script failed for me on the ASDoc example too. Both with > -Duse-flash=true and without. > > This issue seemed familiar, and I rediscovered this comment that I made on > Github, which you might have missed, Yishay. > > > https://github.com/apache/royale-asjs/commit/ce49439ce40f700f0b546d15625be9f09bfbf941#diff-433d3e16953b74f2492217b154b502870224f574cc67ac5415fc230c5ae996b3 > > I can also reproduce this same issue directly in my local royale-asjs repo > by going to examples/royale/ASDoc and running the Ant build script. > > -- > Josh Tynjala > Bowler Hat LLC<https://bowlerhat.dev> > > > On Mon, Jul 26, 2021 at 6:03 AM Piotr Zarzycki <piotrzarzyck...@gmail.com > <mailto:piotrzarzyck...@gmail.com>> wrote: > Hi Yishay, > > I have run approval script and reached compilation point. It looks like > ASDoc module failing for me, but I'm not sure. I will share with you off > the list fragment of stacktrace, cause there are a lot of paths from my > laptop, so don't want to put them here. > > Thanks, > Piotr > > niedz., 25 lip 2021 o 15:14 <apacheroyal...@gmail.com<mailto: > apacheroyal...@gmail.com>> napisał(a): > > > This is the discussion thread. > > > > Thanks, > > Yishay Weiss > > > > -- > > Piotr Zarzycki > > >
