Cool, Greg. Thanks for investigating.
From: Greg Dove<mailto:[email protected]> Sent: Thursday, October 29, 2020 11:48 PM To: Apache Royale Development<mailto:[email protected]> Subject: Re: [royale-asjs] branch develop updated: Fix assertType for js Harbs, I remember that other issue... it was a specific case where a new function was wrapping an imported function with the same base name, (but obviously from a different package). I worked around it by using the import aliasing that Josh added some time ago. I was able to figure out what the issue was with assertType that Yishay was facing. It is related to static initializations of XML instances. The compiler is not getting the static dependencies quite right for some of this stuff yet. The solution (workaround for now) is to make them lazy static getters instead of public static const. -Greg On Fri, Oct 30, 2020 at 8:31 AM Harbs <[email protected]> wrote: > I know Greg ran into a similar problem (with a different method). Maybe he > has suggestions. > > > On Oct 29, 2020, at 8:18 PM, Yishay Weiss <[email protected]> > wrote: > > > > Oddly, I see assert.js the file in the file system > > > > > C:\dev\flexsm5\sm5\sitemaker\royale\toolbar\target\javascript\bin\js-debug\org\apache\royale\debugging\assert.js > > > > but not in dev tools (though network tab says it was loaded) > > > > > > From: Yishay Weiss <[email protected]> > > Sent: Thursday, October 29, 2020 5:58 PM > > To: [email protected] <[email protected]> > > Subject: RE: [royale-asjs] branch develop updated: Fix assertType for js > > > > I do have this line in index.html > > > > goog.addDependency('../../../org/apache/royale/debugging/assert.js', > ['org.apache.royale.debugging.assert'], []); > > > > > > > > From: Yishay Weiss<mailto:[email protected] <mailto: > [email protected]>> > > Sent: Thursday, October 29, 2020 7:54 PM > > To: [email protected]<mailto:[email protected]> > > Subject: RE: [royale-asjs] branch develop updated: Fix assertType for js > > > > I don’t know what’s going on, but after your revert I’m getting the > issue again. In an isolated test case the problem does not show. > > > > > > > > > > From: Harbs<mailto:[email protected] <mailto:[email protected]>> > > Sent: Wednesday, October 28, 2020 12:18 PM > > To: Apache Royale Development<mailto:[email protected] <mailto: > [email protected]>> > > Subject: Re: [royale-asjs] branch develop updated: Fix assertType for js > > > > I reverted and added an import although we should figure out why the > import suddenly became required... > > > > > On Oct 28, 2020, at 12:06 PM, Harbs <[email protected]> wrote: > > > > > > assert is supposed to be org.apache.royale.debugging.assert. > > > > > > Considering it’s in the same package, an import shouldn’t be > necessary, but maybe something happened to the compiler... > > > > > >> On Oct 28, 2020, at 10:17 AM, Yishay Weiss <[email protected]> > wrote: > > >> > > >> I was getting a run-time error. Something like “assert is not a > function of org.apache.royale.debugging.assertType”. When I looked it up > [1] I saw that console.assert() was a js function, but I did now see > window.assert() being a function. > > >> > > >> If I remember correctly it was being called from > XML.addInternalChildren() > > >> > > >> Feel free to change this if you think I made a mistake. > > >> > > >> [1] https://developer.mozilla.org/en-US/docs/Web/API/Console/assert < > https://developer.mozilla.org/en-US/docs/Web/API/Console/assert> > > >> > > >> > > >> From: Harbs<mailto:[email protected] <mailto: > [email protected]>> > > >> Sent: Tuesday, October 27, 2020 6:55 PM > > >> To: [email protected]<mailto:[email protected]> > > >> Subject: Re: [royale-asjs] branch develop updated: Fix assertType for > js > > >> > > >> Why was this necessary? > > >> > > >>> On Oct 27, 2020, at 5:55 PM, [email protected] wrote: > > >>> > > >>> This is an automated email from the ASF dual-hosted git repository. > > >>> > > >>> yishayw pushed a commit to branch develop > > >>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git < > https://gitbox.apache.org/repos/asf/royale-asjs.git> > > >>> > > >>> > > >>> The following commit(s) were added to refs/heads/develop by this > push: > > >>> new 00c5b2a Fix assertType for js > > >>> 00c5b2a is described below > > >>> > > >>> commit 00c5b2ac31a1bbef87a7d388f1bc80476f6ff187 > > >>> Author: Yishay Weiss <[email protected]> > > >>> AuthorDate: Tue Oct 27 15:54:49 2020 +0000 > > >>> > > >>> Fix assertType for js > > >>> --- > > >>> .../Core/src/main/royale/org/apache/royale/debugging/assertType.as > | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git > a/frameworks/projects/Core/src/main/royale/org/apache/royale/debugging/assertType.as > b/frameworks/projects/Core/src/main/royale/org/apache/royale/debugging/assertType.as > > >>> index 647c60f..27c28a2 100644 > > >>> --- > a/frameworks/projects/Core/src/main/royale/org/apache/royale/debugging/assertType.as > > >>> +++ > b/frameworks/projects/Core/src/main/royale/org/apache/royale/debugging/assertType.as > > >>> @@ -36,7 +36,7 @@ package org.apache.royale.debugging > > >>> COMPILE::JS > > >>> { > > >>> if(goog.DEBUG) > > >>> - assert((obj is type),message); > > >>> + console.assert((obj is type),message); > > >>> } > > >>> } > > >>> } > > >>> > > >> > > > > >
