I think I’m going to create a new repo with just the typedefs we’re using. This should make it easier to fix and add typedefs in the future.
> On Jun 25, 2020, at 4:53 PM, Carlos Rovira <[email protected]> wrote: > > Hi Harbs, > > thanks for taking a look. Hope you can solve it and update accordingly. > Maybe we should as well discuss about the need of some infrastructure > behind (ES6?)...but maybe in other thread at other time. At least see how > people see the actual needs. > > Thanks! > > > > El mié., 24 jun. 2020 a las 22:28, Harbs (<[email protected]>) escribió: > >> It needs to be added to typedefs. The definitions are in web_animations.js >> >> I just tried to do that and I ran into the following difficulties: >> >> 1. I noticed that the royale-extra files are very out of date and missing >> the animation defs completely. I tried updating those and broke some tests. >> 2. I also noticed that typed have been more strictly defined, so using the >> newer definitions will require adding more definition files for the missing >> classes (i.e. geometry) >> 3. I also noticed that the closure-compiler files that are downloaded are >> old ones which don’t have changes including the necessary web_animations.js >> file. I’m not sure the best way of solving that problem. We can’t use a >> newer version of closure-compiler because it’s going to require >> royale-compiler changes. >> >> I’m going to look at this again tomorrow, but I figured I should sum up >> what I hit in case someone else wants to take a stab at it… >> >> Harbs >> >>> On Jun 24, 2020, at 10:04 PM, Carlos Rovira <[email protected]> >> wrote: >>> >>> Hi >>> >>> currently to use the animate API [1], I need to use brackets >>> >>> In jewel I have some examples of this: >>> >>> indicator_content["animate"](... >>> >>> or >>> >>> animation = element["animate"](... >>> >>> would be good to be able a dot access so we can do >>> someHTMLelement.animate(...) >>> >>> In fact the API is ready and maybe we are missing to support it. >>> >>> Thoughts? >>> >>> [1] https://developer.mozilla.org/es/docs/Web/API/Element/animate >>> >>> -- >>> Carlos Rovira >>> http://about.me/carlosrovira >> >> > > -- > Carlos Rovira > http://about.me/carlosrovira
