Hi all, so I just created two new PRs that should now bring the maven plugin to use the same defaults as the ant target and I updated all framework modules.
However I just noticed I didn't build the examples so I'll be doing another build including the examples ... so please don't merge them before I reported that the examples are fine now too. Chris Am 20.03.20, 11:26 schrieb "Christofer Dutz" <[email protected]>: Hi all, Greg, Carlos and I just worked on finding out why the Maven build wasn’t failing on some. It took us quite a bit till we tracked it down to allowSubclassOverrides being true in all maven executions. The default is false. A little more searching resulted in BaseMojo having been extended with a property allowSubclassOverrides, which is set to true. So I changed this to false and instantly had Carts fail. So I saw the Ant script sets the class overrides to true and therefore added this to the compiler config of the Charts pom: <allowSubclassOverrides>true</allowSubclassOverrides> and the build passed again. Will be checking which other modules need this setting set. So please, in future: If you add settings to the plugin, do it the right way and don’t just change defaults and then complain that it behaves differently. Chris
