I don’t think it’s appropriate to make cancel the default value in a close event.
> On Apr 4, 2018, at 12:14 PM, Carlos Rovira <[email protected]> wrote: > > Hi, > > I uploaded few days ago the changes exposed here in a branch > ("feature/alert-changes") > Could someone review in order to see if we can merge it in develop? > > thanks > > > > ---------- Forwarded message ---------- > From: Carlos Rovira <[email protected]> > Date: 2018-03-31 23:34 GMT+02:00 > Subject: [Jewel] Alert look screenshot > To: [email protected] > > > *A note about Basic Alert: *I think we should change Basic to match this > since the all parameters except the last are in the same order as Flex, > while Alert in Basic changes this order. As well CloseEvent default flag is > for OK, but I think it should match CANCEL. If you agree in make this two > changes to Basic I can do that. I can make a commit in a develop branch > before do this and if you agree merge with develop > > > > -- > Carlos Rovira > http://about.me/carlosrovira
