mraible commented on code in PR #244:
URL: https://github.com/apache/roller/pull/244#discussion_r4570930131
##########
app/src/main/resources/log4j2.xml:
##########
@@ -74,6 +74,11 @@ limitations under the License.
<Logger name="org.apache.velocity" level="info"
additivity="false"> <AppenderRef ref="asyncRoller"/> </Logger>
<Logger name="org.springframework" level="info"
additivity="false"> <AppenderRef ref="asyncRoller"/> </Logger>
<Logger name="org.apache.struts2" level="info"
additivity="false"> <AppenderRef ref="asyncRoller"/> </Logger>
+ <!-- Struts logs a full stack trace for every request to an unknown
.rol URL; the user gets a 404 -->
+ <Logger name="org.apache.struts2.dispatcher.Dispatcher" level="info"
additivity="false">
+ <RegexFilter regex="Could not find action or result: .*"
onMatch="DENY" onMismatch="NEUTRAL"/>
+ <AppenderRef ref="asyncRoller"/>
+ </Logger>
Review Comment:
I agree with removing the filter rather than hiding a misconfigured action
(see the thread on line 79). This suggestion deletes it:
```suggestion
```
##########
CHANGES.md:
##########
@@ -41,6 +41,15 @@
- **The rich text editor's menus show their labels again.** Summernote is
upgraded to 0.9.1, and the panel chevron no longer appears on the
editor's menu items.
+- **Fixes found while upgrading a 6.1 site to a 7.0.0 snapshot.**
+ - The database create and upgrade result pages show a clear status, one
+ Start Roller button, and the script output in a panel you can expand.
+ - The media library opens for weblogs that have no default media folder;
+ it creates the folder instead of failing.
+ - A custom template with no content logs one warning line instead of a
+ stack trace, and requests for unknown pages no longer log one either.
Review Comment:
With the filter gone, unknown pages still log a stack trace, so this line
should drop that part:
```suggestion
- A custom template with no content logs one warning line instead of a
stack trace.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
