mraible opened a new pull request, #250: URL: https://github.com/apache/roller/pull/250
After moving a copy of my site to a 7.0.0 snapshot, the About, Archives and Contact links were gone from my weblog's menu. The pages still worked at their URLs and were still marked to appear in the menu. `#showPageMenu` in `weblog.vm` loops over `$weblog.pages`, and so do the menus in the Gaurav and PaperMod themes. The template guide documents `$weblog.pages` too. But `WeblogWrapper` has no `getPages()`. It went away in 91eb476de, when templates were reworked, and `getTemplates()` took its place. Velocity treats the missing property as an empty list, so the loop does nothing and no error is logged. This adds `getPages()` back as another name for `getTemplates()`. That fixes the macro and both themes, keeps the documented name working, and fixes any site theme written against the guide. There's a unit test for the wrapper. I haven't run the stock macro in a browser with this change; on my copy I'd worked around it by looping over `$weblog.templates` in a site macro, which did bring the links back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
