mraible commented on PR #156:
URL: https://github.com/apache/roller/pull/156#issuecomment-6104078214
Thanks for the audit, Dave. Both regressions from this PR are fixed:
- UI-01: all 14 `.modal({show: true})` calls (one more than the audit
listed) now use `.modal('show')`, so the category, blogroll, entry delete,
Insert Media File, media lightbox and ping target dialogs open again.
- UI-02: the seven label-less tags are back on `theme="simple"`, as on
master. Publishing time is a single `HH : MM : SS` row of fixed-width selects,
the body and summary editors line up with the other fields, and the blogroll
move-to select sizes to the folder name.
While merging I also found that the User Edit page's Save and Cancel buttons
still used Bootstrap 3 classes, so they now use `btn-primary` and
`btn-outline-secondary`.
#157 now covers the dialogs in all three auth modes. The tests add a
category through the dialog, cancel an entry delete, insert a media file
through the chooser, and check that the publishing time renders on one line.
The rest of the audit isn't from this PR. UI-03, UI-07 and the Dispatch
overflow (UI-08 #1) are fixed in #160, and UI-04 (OIDC logout) is fixed in
#155. UI-05 (viewport meta, sidebar order, table overflow), UI-06 (calendar
icons), the unstyled 403 page, the `rUNKNOWN` revision, the Gaurav preview
fonts, the Frontpage preview and the Design menu gating are the same on master,
so I'd rather handle them in separate PRs than grow this one. I haven't yet
checked whether UI-08 #3 to #6 (accordion headers, login page polish, blogroll
switcher, sidebar spacing) come from this PR or exist on master.
The whole stack has master merged in now, through #154.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
