mraible commented on PR #155: URL: https://github.com/apache/roller/pull/155#issuecomment-6104041437
Dave's UI audit on #156 (UI-04) found that logging out of Roller left the Keycloak session alive, so the next "Sign in with Keycloak" signed straight back in. The OIDC code lives here, so I fixed it in this PR (ec5cbf190). Users who signed in through an OIDC provider are now sent to the provider's `end_session_endpoint` with an `id_token_hint`, and the provider returns them to Roller's front page. Form-login users, and providers that don't advertise an end-session endpoint, keep the existing redirect to the front page. I verified it against the docker-compose Keycloak (logout goes through Keycloak and back to Roller, and the next sign-in shows the Keycloak login form) and added `LogoutRedirectTest`. This branch also has #154's master merge now. @snoopdave since you'd already approved this PR, could you take another look at ec5cbf190? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
