mraible commented on code in PR #160:
URL: https://github.com/apache/roller/pull/160#discussion_r4239721765
##########
app/src/main/webapp/themes/alpenglow/day.vm:
##########
@@ -0,0 +1,28 @@
+#foreach($entry in $entries)
+<article class="story">
+ <div class="story-index" aria-hidden="true">$velocityCount</div>
Review Comment:
Fixed. It uses `$foreach.count` now.
##########
app/src/main/webapp/themes/dispatch/day.vm:
##########
@@ -0,0 +1,30 @@
+#foreach($entry in $entries)
+<article class="dispatch">
+ <div class="dispatch-number">#if($velocityCount<10)0#end$velocityCount</div>
Review Comment:
Fixed with `#if($foreach.count < 10)0#end$foreach.count`, so entries show
01, 02, and so on.
##########
app/src/main/webapp/themes/alpenglow/footer.vm:
##########
@@ -0,0 +1,10 @@
+<footer class="site-footer">
+ <p>
+ <strong>$model.weblog.name</strong>
+ — #if($model.weblog.tagline)$model.weblog.tagline#elseField notes from a
life in motion.#end
Review Comment:
Good catch. The fallback text was hard-coded persona copy, so I removed it
instead of switching to `#{else}`. The footer now shows the tagline only when
the weblog has one.
##########
app/src/main/webapp/themes/horizon/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags — $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="article-shell">
+ <header class="page-heading">
+ <p class="eyebrow">Topic</p>
+ <h1>$model.tags</h1>
Review Comment:
Fixed here and in the `<title>` on line 5. The tags are joined with a
`#foreach`, so a multi-tag page reads `java, roller`.
##########
app/src/main/webapp/themes/alpenglow/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags — $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="reading-shell">
+ <header class="page-title">
+ <p class="kicker">Stories filed under</p>
+ <h1>$model.tags</h1>
Review Comment:
Fixed here and in the `<title>`, the same way as Horizon.
##########
app/src/main/webapp/themes/dispatch/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags / $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="reading-shell">
+ <header class="page-title">
+ <p class="label">FILTER / TAG</p>
+ <h1>$model.tags</h1>
Review Comment:
Fixed here and in the `<title>`, the same way as Horizon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
