snoopdave commented on a change in pull request #51: made it easier to run roller on latest JVMs (tested with JDK 13). URL: https://github.com/apache/roller/pull/51#discussion_r349883246
########## File path: version-rules.xml ########## @@ -0,0 +1,16 @@ +<ruleset comparisonMethod="maven" + xmlns="http://mojo.codehaus.org/versions-maven-plugin/rule/2.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://mojo.codehaus.org/versions-maven-plugin/rule/2.0.0 http://mojo.codehaus.org/versions-maven-plugin/xsd/rule-2.0.0.xsd";> + <ignoreVersions> + <!--only release builds--> + <ignoreVersion type="regex">.*(alpha|ALPHA|beta|BETA|b|rc|RC|M).*</ignoreVersion> + + <!--ignore some specific version strings which don't follow the common version format--> + <ignoreVersion type="exact">20020829</ignoreVersion> Review comment: What is the purpose of these ignoreVersions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
