Hi Greg,
That's a good idea. The name WeblogTemplateCode implies something that
is associated with a weblog, and that is not the case with the new
code. I introduced a new interface Template code with this hierarchy:
TemplateCode - interface representing template code for one type of
device (e.g. standard, mobile)
SharedThemeTemplateCode - template code for a shared weblog theme
WeblogThemeTemplateCode - template code for theme associated
with a weblog
Have you been working with the new template system and developing any
mobile-ready themes?
Thanks,
Dave
On Thu, Nov 24, 2011 at 3:56 AM, Greg Huber <gregh3...@gmail.com> wrote:
> Dave,
>
> If you are looking at the code, and to be more sympathetic to the
> current design, it might be worth creating an interface for
> ThemeTemplateCode and have WeblogTemplateCode implement it. Then
> create a SharedThemeTemplateCode which also also implements
> ThemeTemplateCode. This way you keep WeblogTemplateCode out of
> org.apache.roller.weblogger.business.themes. package. Bit of extra
> work mind!
>
> Cheers Greg
>
> On 20 November 2011 14:54, Dave <snoopd...@gmail.com> wrote:
>> Thanks Greg,
>>
>> I just made a fix for this in both of those page cache classes.
>>
>> - Dave
>>
>>
>>
>> On Tue, Sep 20, 2011 at 3:26 PM, Greg Huber <gregh3...@gmail.com> wrote:
>>> Shelan,
>>>
>>> Sorry, whilst I remember, may also need the type code in the
>>> WeblogPageCache & SiteWideCache generateKey(WeblogPageRequest
>>> pageRequest) method to get the correct page when loading from the
>>> cache.
>>>
>>> ie
>>> key.append("/type=").append(pageRequest.getType());
>>>
>>>
>>> Cheers Greg.
>>>
>>
>>
>>
>> --
>> Dave M. Johnson
>> Apache Roller PMC Chair
>> http://rollerweblogger.org/roller
>>
>
--
Dave M. Johnson
Apache Roller PMC Chair
http://rollerweblogger.org/roller
