Thanks Anil. I just picked that up. So far, I've got these fixes in the Roller 3.1 RC: - Corrected references to legacy $entry variable in three included blog themes - Also fixed in all Roller Support project themes at roller.dev.java.net - Use Number instead of Integer for SQL sum() results - I18N fix for "In Category" string in weblog.vm
And these in the Roller 3.0 RC: - Corrected references to legacy $entry variable in three included blog themes I'm uploading the RC files now. I'll wait until later to announce the RCs to allow for further review of the changes in SVN (and further bleaching and scrubbing of my %^&@#! screened-in porch). - Dave On 4/21/07, Anil Gangolli <[EMAIL PROTECTED]> wrote:
There was one additional instance found in my fixes. I committed as http://svn.apache.org/viewvc?view=rev&rev=531069 --a. ----- Original Message ----- From: "Dave" <[EMAIL PROTECTED]> To: <dev@roller.apache.org> Sent: Saturday, April 21, 2007 9:59 AM Subject: Re: 3.1 release approved by Roller PMC (was Re: Release Apache Roller 3.1 RC8) > Please review. I just committed fixes to trunk and branches/roller_3.1 > > - Dave > > > > On 4/21/07, Anil Gangolli <[EMAIL PROTECTED]> wrote: >> >> Dave, I'd like to review; I had fixes prepared for 3.1; >> >> There are occurrences in both the HibernateWelbogManagerImpl and >> HibernateReferrerManagerImpl and I want to make sure we got all of them. >> >> Alternately, I can commit. >> --a. >> >> >> ----- Original Message ----- >> From: "Dave" <[EMAIL PROTECTED]> >> To: <dev@roller.apache.org> >> Sent: Saturday, April 21, 2007 9:20 AM >> Subject: Re: 3.1 release approved by Roller PMC (was Re: Release Apache >> Roller 3.1 RC8) >> >> >> > On 4/21/07, Anil Gangolli <[EMAIL PROTECTED]> wrote: >> >> Allen or Dave, can you look at ROL-1391 and comment on whether you >> >> think >> >> we >> >> also need to include a fix for that in 3.1 before release? >> >> >> >> It just came up. I realized I didn't exercise that path on my crude >> >> smoke >> >> test. Has it shown up in your testing? There has been one similar >> >> complaint about the dayhits calculations throwing ClassCastException >> >> in >> >> e-mail on the users list. >> > >> > Yes, I think switching to Number for all sum results makes sense. I >> > think it's a safe fix and I'm committing it to trunk and the new 3.1 >> > RC. >> > >> > - Dave >> > >> >> >
