[GitHub] [rocketmq] iamqq23ue opened a new pull request, #4219: [ISSUE #4215] OFFSET_OVERFLOW_BADLY will lead to consumption from begin, a large number of repeated consumption

Wed, 27 Apr 2022 01:48:44 -0700 


iamqq23ue opened a new pull request, #4219:
URL: https://github.com/apache/rocketmq/pull/4219

   In  DefaultMessageStore.java ，There is the following code：
   
   else if (offset > maxOffset) {
                   status = GetMessageStatus.OFFSET_OVERFLOW_BADLY;
                   if (0 == minOffset) {
                       nextBeginOffset = nextOffsetCorrection(offset, 
minOffset);
                   } else {
                       nextBeginOffset = nextOffsetCorrection(offset, 
maxOffset);
                   }
   
   It can be seen that if minOffset=0.Consumption will start from 0.
   
   I suggest modifying to:
   
   else if (offset > maxOffset) {
                   status = GetMessageStatus.OFFSET_OVERFLOW_BADLY;
                   nextBeginOffset = nextOffsetCorrection(offset, maxOffset);
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to