zhaohai1299002788 commented on a change in pull request #3:
URL: https://github.com/apache/rocketmq-connect/pull/3#discussion_r834894086



##########
File path: 
connectors/aliyun/rocketmq-connect-http/src/main/java/org/apache/rocketmq/connect/http/sink/HttpSinkTask.java
##########
@@ -0,0 +1,68 @@
+package org.apache.rocketmq.connect.http.sink;
+
+import com.alibaba.fastjson.JSON;
+import org.apache.rocketmq.connect.http.sink.common.OkHttpUtils;
+import org.apache.rocketmq.connect.http.sink.constant.HttpConstant;
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.sink.SinkTask;
+import io.openmessaging.connector.api.component.task.sink.SinkTaskContext;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.errors.ConnectException;
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class HttpSinkTask extends SinkTask {
+    private static final Logger log = 
LoggerFactory.getLogger(HttpSinkTask.class);
+
+    private String url;
+
+    @Override
+    public void put(List<ConnectRecord> sinkRecords) throws ConnectException {
+        try {
+            sinkRecords.forEach(connectRecord -> {
+                OkHttpUtils.builder()
+                        .url(url)
+                        .addParam(HttpConstant.DATA_CONSTANT, 
JSON.toJSONString(connectRecord.getData()))

Review comment:
       已处理

##########
File path: 
connectors/aliyun/rocketmq-connect-http/src/main/java/org/apache/rocketmq/connect/http/sink/HttpSinkConnector.java
##########
@@ -0,0 +1,67 @@
+package org.apache.rocketmq.connect.http.sink;
+
+import org.apache.rocketmq.connect.http.sink.constant.HttpConstant;
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.Task;
+import io.openmessaging.connector.api.component.task.sink.SinkConnector;
+import io.openmessaging.internal.DefaultKeyValue;
+import org.apache.commons.lang3.StringUtils;
+
+import java.net.URL;
+import java.net.URLConnection;
+import java.util.ArrayList;
+import java.util.List;
+
+public class HttpSinkConnector extends SinkConnector {
+
+    private String url;
+
+    @Override
+    public void pause() {
+
+    }
+
+    @Override
+    public void resume() {
+
+    }
+
+    @Override
+    public List<KeyValue> taskConfigs(int maxTasks) {
+        List<KeyValue> keyValueList = new ArrayList<>(11);
+        KeyValue keyValue = new DefaultKeyValue();
+        keyValue.put(HttpConstant.URL_CONSTANT, url);
+        keyValueList.add(keyValue);
+        return keyValueList;
+    }
+
+    @Override
+    public Class<? extends Task> taskClass() {
+        return HttpSinkTask.class;
+    }
+
+    @Override
+    public void validate(KeyValue config) {
+        if (StringUtils.isBlank(config.getString(HttpConstant.URL_CONSTANT))) {
+            throw new RuntimeException("http required parameter is null !");
+        }
+        try {
+            URL urlConnect = new URL(url);
+            URLConnection urlConnection = urlConnect.openConnection();

Review comment:
       已处理




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to