2011shenlin commented on a change in pull request #3:
URL: https://github.com/apache/rocketmq-connect/pull/3#discussion_r834047982



##########
File path: 
connectors/aliyun/rocketmq-connect-http/src/main/java/org/apache/rocketmq/connect/http/sink/HttpSinkTask.java
##########
@@ -0,0 +1,68 @@
+package org.apache.rocketmq.connect.http.sink;
+
+import com.alibaba.fastjson.JSON;
+import org.apache.rocketmq.connect.http.sink.common.OkHttpUtils;
+import org.apache.rocketmq.connect.http.sink.constant.HttpConstant;
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.sink.SinkTask;
+import io.openmessaging.connector.api.component.task.sink.SinkTaskContext;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.errors.ConnectException;
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class HttpSinkTask extends SinkTask {
+    private static final Logger log = 
LoggerFactory.getLogger(HttpSinkTask.class);
+
+    private String url;
+
+    @Override
+    public void put(List<ConnectRecord> sinkRecords) throws ConnectException {
+        try {
+            sinkRecords.forEach(connectRecord -> {
+                OkHttpUtils.builder()
+                        .url(url)
+                        .addParam(HttpConstant.DATA_CONSTANT, 
JSON.toJSONString(connectRecord.getData()))

Review comment:
       直接connectRecord.getData().toString() 就可以了,不要做JOSN序列化,其他的connector一并处理下




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to