zhaohai1299002788 commented on a change in pull request #3:
URL: https://github.com/apache/rocketmq-connect/pull/3#discussion_r821387035
##########
File path:
connectors/aliyun/rocketmq-connect-http/src/main/java/com/aliyun/rocketmq/connect/http/sink/HttpSinkTask.java
##########
@@ -0,0 +1,68 @@
+package com.aliyun.rocketmq.connect.http.sink;
+
+import com.alibaba.fastjson.JSON;
+import com.aliyun.rocketmq.connect.http.sink.common.OkHttpUtils;
+import com.aliyun.rocketmq.connect.http.sink.constant.HttpConstant;
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.sink.SinkTask;
+import io.openmessaging.connector.api.component.task.sink.SinkTaskContext;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.errors.ConnectException;
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class HttpSinkTask extends SinkTask {
+ private static final Logger log =
LoggerFactory.getLogger(HttpSinkTask.class);
+
+ private String url;
+
+ @Override
+ public void put(List<ConnectRecord> sinkRecords) throws ConnectException {
+ try {
+ sinkRecords.forEach(connectRecord -> {
+ OkHttpUtils.builder()
+ .url(url)
+ .addParam(HttpConstant.DATA_CONSTANT,
JSON.toJSONString(connectRecord.getData()))
+ .post(true)
+ .sync();
+ });
+ } catch (Exception e) {
+ log.error("HttpSinkTask | put | error => ", e);
+ }
+ }
+
+ @Override
+ public void pause() {
+
+ }
+
+ @Override
+ public void resume() {
+
+ }
+
+ @Override
+ public void validate(KeyValue config) {
+ if (StringUtils.isBlank(config.getString("url"))) {
+ throw new RuntimeException("http required parameter is null !");
+ }
Review comment:
add check whether the URL can be accessed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
