[ 
https://issues.apache.org/jira/browse/PROTON-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273886#comment-17273886
 ] 

Pete Fawcett commented on PROTON-2330:
--------------------------------------

[~astitcher]
 As per your request / suggestion I have submitted a PR to enable access to 
Link Properties from the C++ API - following the same approach as taken for 
Connection Properties.

You also observed that Sessions have properties. However, this looks to be 
rather more complicated.

The [AMQP 1.0 
Spec|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-begin]
 for the "Begin" frame does indeed describe a "properties" field, but I can't 
see any existing support for this in the Proton C library (ditto for the 
"offered-capabilities" and "desired-capabilities" fields)

This looks to be where the BEGIN frame is built in 
[transport.c|https://github.com/apache/qpid-proton/blob/master/c/src/core/transport.c#L2056]
 which makes no references to capabilities or properties.

>From this I would conclude that:
 # Supporting properties on sessions would be a significantly bigger piece of 
work than for connections and links
 # Session properties are not supported at all in QPID Proton and therefore 
no-one is using them

As a result I am proposing to restrict the scope of this ticket to just 
handling link properties.

If there is a specific user requirement to handle session properties then a new 
ticket could be opened.

What do you think?

> Allow access to session and link properties in cpp binding 
> -----------------------------------------------------------
>
>                 Key: PROTON-2330
>                 URL: https://issues.apache.org/jira/browse/PROTON-2330
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>    Affects Versions: proton-c-0.33.0
>            Reporter: Pete Fawcett
>            Priority: Minor
>
> As per the work done in PROTON-2307 for connection properties, extend the 
> same approach to allow the setting of custom properties on sessions and links.
> Also allow retrieval of such properties as set by remote end on sessions and 
> links.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to