[ 
https://issues.apache.org/jira/browse/PROTON-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247231#comment-17247231
 ] 

ASF GitHub Bot commented on PROTON-2307:
----------------------------------------

gemmellr commented on pull request #278:
URL: https://github.com/apache/qpid-proton/pull/278#issuecomment-742512456


   I believe some of the builds are a little flakey in CI (and there are also 
some tests enabled in CI that aren't in the default build because of that). If 
you are confident the failures aren't from your changes then feel free to just 
say so. Another approach is to give the build a prod and see if anything 
changes (e.g git commit --amend --reset-author to redo the commit, followed by 
a force push). 
   
   You don't need to get the tests passing to elicit a review, you just need 
someone with the requisite knowledge to actually come along (which is not me 
I'm afraid).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow access to connection properties in cpp binding
> ----------------------------------------------------
>
>                 Key: PROTON-2307
>                 URL: https://issues.apache.org/jira/browse/PROTON-2307
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>    Affects Versions: proton-c-0.33.0
>            Reporter: Pete Fawcett
>            Priority: Minor
>
> I would like to be able to set the "custom" properties on a connection using 
> the C++ bindings.
> The initial reason for this is to allow a client program to set the 
> "qpid.client_process" property on a connection to a broker as this is useful 
> when identifying the connection on the QMF console.
> I have written code to enable this and hope to submit a pull request soon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to