----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29160/ -----------------------------------------------------------
Review request for qpid, Alan Conway, Chug Rolke, and Justin Ross. Bugs: QPID-6256 https://issues.apache.org/jira/browse/QPID-6256 Repository: qpid Description ------- * have a specific exception for signalling protocol mismatch up the stack * use this to try alternative(s) in the event protocol is not explicitly specified and first choice isn't supported by peer Diffs ----- trunk/qpid/cpp/include/qpid/messaging/exceptions.h 1646261 trunk/qpid/cpp/src/qpid/Exception.h 1646261 trunk/qpid/cpp/src/qpid/client/Connection.cpp 1646261 trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp 1646261 trunk/qpid/cpp/src/qpid/client/Connector.h 1646261 trunk/qpid/cpp/src/qpid/client/Connector.cpp 1646261 trunk/qpid/cpp/src/qpid/client/RdmaConnector.cpp 1646261 trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1646261 trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp 1646261 trunk/qpid/cpp/src/qpid/client/amqp0_10/ConnectionImpl.cpp 1646261 trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.h 1646261 trunk/qpid/cpp/src/qpid/messaging/Connection.cpp 1646261 trunk/qpid/cpp/src/qpid/messaging/ConnectionImpl.h 1646261 trunk/qpid/cpp/src/qpid/messaging/ProtocolRegistry.cpp 1646261 trunk/qpid/cpp/src/qpid/messaging/exceptions.cpp 1646261 Diff: https://reviews.apache.org/r/29160/diff/ Testing ------- * make test passes * connects to qpidd when 0-10 has been disabled on broker * connects to rabbitmq * didn't connect to activemq 5.10 due to AMQ-5490, but that is fixed so should work against trunk (to be verified) Thanks, Gordon Sim