[ 
https://issues.apache.org/jira/browse/PROTON-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088588#comment-18088588
 ] 

Andrew Stitcher commented on PROTON-2770:
-----------------------------------------

Technically the documentation does say that the only threasd safe connection 
level API is proton::connection:::wake(), but it is not clear the work_queue() 
accessor is not thread safe -  and since it is entrely there for thread safety 
it should either be thread safe or explicitly noted as not thread safe 
everywhere!

> Getting the work queue with proton::link::work_queue() is not thread safe
> -------------------------------------------------------------------------
>
>                 Key: PROTON-2770
>                 URL: https://issues.apache.org/jira/browse/PROTON-2770
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: proton-c-0.39.0
>            Reporter: Jean-François Simoneau
>            Assignee: Andrew Stitcher
>            Priority: Major
>
> The accessor proton::link::work_queue() returns a reference to the 
> proton::work_queue(), but making that call uses the link::container() method 
> that increases the refcount on the pn_connection, making this function 
> uncallable from outside of the work_queue.
> I believe the documentation should make that explicit, or the function should 
> be changed to be thread safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to