[
https://issues.apache.org/jira/browse/QPID-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18010344#comment-18010344
]
Robert Godfrey commented on QPID-8706:
--------------------------------------
I'm not sure I completely agree with this change. Previously the definition of
the constants was essentially aligned with where in the spec the constants were
defined - e.g. the properties related to the soleconn extension were defined in
broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/type/extensions/soleconn/SoleConnectionConnectionProperties.java.
After this change they are all defined in a single file (or rather two files
- one of Strings, one of Symbols). The fact that all these text values are
symbols doesn't seem to me to be a sufficient reason to dump them all in a
single place - functionally they are related to different parts of the spec.
That having been said, I don't massively object - I just think the is worse
from a code organisation point of view.
> Move AMQP-1.0 symbols declarations to a utility class
> -----------------------------------------------------
>
> Key: QPID-8706
> URL: https://issues.apache.org/jira/browse/QPID-8706
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-9.2.1
> Reporter: Daniil Kirilyuk
> Priority: Minor
> Fix For: qpid-java-broker-10.0.0
>
>
> Currently in qpid-broker-plugins-amqp-1-0-protocol all Symbol instance are
> created via Symbol.valueOf(). Although they are cached internally, to improve
> the code readability it would be beneficial to move all constant Symbols to
> the utility class as public static final constants.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
