[ https://issues.apache.org/jira/browse/PROTON-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945394#comment-17945394 ]
ASF GitHub Bot commented on PROTON-1442: ---------------------------------------- DreamPearl commented on code in PR #437: URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2048940456 ########## cpp/src/transfer.cpp: ########## @@ -50,6 +52,16 @@ enum transfer::state transfer::state() const { return static_cast<enum state>(pn std::string to_string(enum transfer::state s) { return pn_disposition_type_name(s); } std::ostream& operator<<(std::ostream& o, const enum transfer::state s) { return o << to_string(s); } +void transfer::transaction(proton::transaction t) { + transfer_context &cc = transfer_context::get(pn_object()); + cc.transaction_ = std::make_unique<proton::transaction>(t); +} + +transaction transfer::transaction() const { + transfer_context& cc = transfer_context::get(pn_object()); + return *cc.transaction_; +} + Review Comment: Removed. Transfer no longer holds the transaction now. > [c++] Support for transactions > ------------------------------ > > Key: PROTON-1442 > URL: https://issues.apache.org/jira/browse/PROTON-1442 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Reporter: Radim Kubis > Assignee: Rakhi Kumari > Priority: Major > > Support for transactions in Qpid Proton C++. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org