DreamPearl commented on code in PR #437:
URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2048940456


##########
cpp/src/transfer.cpp:
##########
@@ -50,6 +52,16 @@ enum transfer::state transfer::state() const { return 
static_cast<enum state>(pn
 std::string to_string(enum transfer::state s) { return 
pn_disposition_type_name(s); }
 std::ostream& operator<<(std::ostream& o, const enum transfer::state s) { 
return o << to_string(s); }
 
+void transfer::transaction(proton::transaction t) {
+    transfer_context &cc = transfer_context::get(pn_object());
+    cc.transaction_ = std::make_unique<proton::transaction>(t);
+}
+
+transaction transfer::transaction() const {
+    transfer_context& cc = transfer_context::get(pn_object());
+    return *cc.transaction_;
+}
+

Review Comment:
   Removed. Transfer no longer holds the transaction now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to