gemmellr commented on code in PR #1741: URL: https://github.com/apache/qpid-dispatch/pull/1741#discussion_r1915349523
########## packaging/README.adoc: ########## @@ -0,0 +1,39 @@ +//// +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License +//// + += Packaging + +== rpm + +The https://packit.dev/docs/cli[`packit` tool] expects to have a `.packit.yaml` file at the source root. + +.Example: install build dependencies +[source,shell script] +---- +dnf install 'dnf-command(builddep)' +dnf builddep -y packaging/skupper-router.spec Review Comment: Seems questionable ########## .packit.yaml: ########## @@ -0,0 +1,40 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# See the documentation for more information: +# https://packit.dev/docs/configuration/ + +# https://packit.dev/docs/configuration/#top-level-keys +upstream_project_url: https://qpid.apache.org/components/dispatch-router +issue_repository: https://issues.apache.org/jira/projects/DISPATCH/issues + +specfile_path: packaging/qpid-dispatch.spec Review Comment: If this is aimed at testing changes with fedora-rawhide then the structure should perhaps convey that rather than simply using a root of 'packaging' ? ########## packaging/dispatch.patch: ########## @@ -0,0 +1,30 @@ +diff --git a/etc/qdrouterd.conf b/etc/qdrouterd.conf +index 4e8e506c..add40c69 100644 +--- a/etc/qdrouterd.conf ++++ b/etc/qdrouterd.conf +@@ -32,6 +32,13 @@ listener { + saslMechanisms: ANONYMOUS + } + ++listener { Review Comment: Seems unclear that it should have a different default config for this? Coming back after later looks...is this intended for the console? Unclear if that bit of the spec is even being used? If so and if not, surely this shouldnt be there? ########## packaging/qpid-dispatch.spec: ########## @@ -0,0 +1,515 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Copyright Fedora Project Authors. +# This code is licensed under MIT license + +# Currently orphaned in Fedora +# - https://pagure.io/releng/issue/12278 +# - https://bugzilla.redhat.com/2245601 + +# This package depends on automagic byte compilation +# https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation_phase_2 +%global py_byte_compile 1 +%global __cmake_in_source_build 1 + +# Define pkgdocdir for releases that don't define it already +%{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} + +%global _console_subpackage 0 +%global _use_systemd 1 + +%global proton_minimum_version 0.34.0 +%global libwebsockets_minimum_version 3.2.0 +%global libnghttp2_minimum_version 1.33.0 + +%undefine __brp_mangle_shebangs + +Name: qpid-dispatch +Version: 3.1.0 +Release: 9.20250113093119135559.jd_fix_build.65.g76e0c22d%{?dist} +Summary: Dispatch router for Qpid +License: ASL 2.0 +URL: http://qpid.apache.org/ +Source0: qpid-dispatch-3.1.0.tar.gz Review Comment: Hmm again. More below. ########## packaging/qpid-dispatch.spec: ########## @@ -0,0 +1,515 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Copyright Fedora Project Authors. +# This code is licensed under MIT license + +# Currently orphaned in Fedora +# - https://pagure.io/releng/issue/12278 +# - https://bugzilla.redhat.com/2245601 + +# This package depends on automagic byte compilation +# https://fedoraproject.org/wiki/Changes/No_more_automagic_Python_bytecompilation_phase_2 +%global py_byte_compile 1 +%global __cmake_in_source_build 1 + +# Define pkgdocdir for releases that don't define it already +%{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} + +%global _console_subpackage 0 +%global _use_systemd 1 + +%global proton_minimum_version 0.34.0 +%global libwebsockets_minimum_version 3.2.0 +%global libnghttp2_minimum_version 1.33.0 + +%undefine __brp_mangle_shebangs + +Name: qpid-dispatch +Version: 3.1.0 Review Comment: Hmm? ########## packaging/qpid-dispatch.spec: ########## @@ -0,0 +1,515 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Copyright Fedora Project Authors. +# This code is licensed under MIT license Review Comment: The header and following statements seem in conflict. Things licenced to the foundation and using the ASF specific header, dont have copyright notices included, and certainly not ones attributing it to another project. I thought your plan was to write a new file, but if this is just a lift of a Fedora file then it could simply remain MIT and be referenced as such in the LICENCE file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
